Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

Starknet foundry snforge updated #226

Merged
merged 4 commits into from
Oct 23, 2023
Merged

Starknet foundry snforge updated #226

merged 4 commits into from
Oct 23, 2023

Conversation

Akinbola247
Copy link
Contributor

hi, @omarespejel In reference to this issue #219 , i have updated the chapter as per request. Kindly review this and give a feedback. You can also take a look at the code reference used in computing the chapter here https://github.com/Akinbola247/ERC20-Starknet-Foundry

@dalmasonto
Copy link
Contributor

Hello @Akinbola247, seems like prettier is failing to run. Kindly update your source code, install the js dependencies and run the prettier command from package json file then push again

@Akinbola247
Copy link
Contributor Author

Hello @Akinbola247, seems like prettier is failing to run. Kindly update your source code, install the js dependencies and run the prettier command from package json file then push again

apparently the issue came from a commit from src/ch04-01-accounts.md that i pulled into my local machine

@dalmasonto
Copy link
Contributor

Okay, have you tried running the linter locally?

@Akinbola247
Copy link
Contributor Author

I've fixed it. Thanks for calling my attention to it @dalmasonto

@dalmasonto
Copy link
Contributor

Welcome, it has worked as expected!

@omarespejel omarespejel merged commit 2b2f4f5 into starknet-edu:main Oct 23, 2023
1 check failed
@omarespejel
Copy link
Collaborator

hey @Akinbola247! Thank you for the PR! I merged it and will review and edit it ASAP and come back with feedback if there is any.

Also thank you @dalmasonto for reviewing 🙏

@omarespejel
Copy link
Collaborator

Hi @Akinbola247,

I've reviewed your contribution and made some formatting edits. It's looking nice! Just a couple of final touches are needed:

  • Could you embed links to references within the chapter? This would enable students to delve deeper into the topics. For instance, a link to documentation on fuzz tests or other cheat codes would be beneficial.
  • a brief summary at the end highlighting key takeaways would be a great addition.

Thank you once more!

@Akinbola247
Copy link
Contributor Author

Hi @Akinbola247,

I've reviewed your contribution and made some formatting edits. It's looking nice! Just a couple of final touches are needed:

  • Could you embed links to references within the chapter? This would enable students to delve deeper into the topics. For instance, a link to documentation on fuzz tests or other cheat codes would be beneficial.
  • a brief summary at the end highlighting key takeaways would be a great addition.

Thank you once more!

Sure! @omarespejel. Thanks for the review, I’ll get it done right away.

@omarespejel
Copy link
Collaborator

Thanks, @Akinbola247! Note I've made edits to the chapter. Ensure you 'git pull' to see the updates before your next PR.

@Akinbola247
Copy link
Contributor Author

hey @omarespejel an observation here https://book.starknet.io/ch02-12-foundry-forge.html
a code snippet in the "Full erc20 test example file" is outside the code section box. I sent you a screenshot on telegram.

@Akinbola247
Copy link
Contributor Author

Akinbola247 commented Oct 23, 2023

hi @omarespejel i've mad

Hi @Akinbola247,

I've reviewed your contribution and made some formatting edits. It's looking nice! Just a couple of final touches are needed:

  • Could you embed links to references within the chapter? This would enable students to delve deeper into the topics. For instance, a link to documentation on fuzz tests or other cheat codes would be beneficial.
  • a brief summary at the end highlighting key takeaways would be a great addition.

Thank you once more!

Hi @omarespejel i've added the reference links and key take aways. You can check the PR here #229

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants